Update cluster and linked services API by orargaman · Pull Request #8674 · Azure/azure-rest-api-specs

orargaman · 2020-03-11T07:58:12Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Fix

azure-pipelines · 2020-03-11T08:01:23Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-03-11T08:03:18Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-03-11T08:38:51Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8210d51 with merge commit 64541c6. SDK Automation 13.0.17.20200326.3
⚠️operationalinsights/mgmt/2015-03-20 [Logs]
```
No file is changed.
```
️✔️preview/operationalinsights/mgmt/2015-11-01-preview [Logs] [Release SDK Changes]
- preview.operationalinsights.mgmt.2015-11-01-preview.zip

openapi-sdkautomation · 2020-03-11T08:38:57Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-03-11T08:39:09Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8210d51 with merge commit 64541c6. SDK Automation 13.0.17.20200326.3
️✔️Microsoft.Azure.Management.OperationalInsights [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.OperationalInsights.0.19.0-preview.nupkg
- Microsoft.Azure.Management.OperationalInsights.0.19.0-preview.snupkg

openapi-sdkautomation · 2020-03-11T08:39:21Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8210d51 with merge commit 64541c6. SDK Automation 13.0.17.20200326.3

️✔️@azure/arm-operationalinsights [Logs] [Release SDK Changes]

azure-arm-operationalinsights-1.2.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-operationalinsights@1.2.0~prepack: cannot run in wd @azure/arm-operationalinsights@1.2.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/operationalinsights/arm-operationalinsights)

openapi-sdkautomation · 2020-03-11T08:39:44Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8210d51 with merge commit 64541c6. SDK Automation 13.0.17.20200326.3

⚠️azure-mgmt-loganalytics [Logs] [Release SDK Changes] Breaking Change Detected

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 19.139% size of original (original: 16631 chars, delta: 3183 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Added operation group OperationalInsightsManagementClientOperationsMixin
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Removed operation WorkspacesOperations.purge
[ChangeLog]   - Removed operation WorkspacesOperations.get_search_results
[ChangeLog]   - Removed operation WorkspacesOperations.get_schema
[ChangeLog]   - Removed operation WorkspacesOperations.update_search_results
[ChangeLog]   - Removed operation WorkspacesOperations.list_link_targets
[ChangeLog]   - Removed operation group StorageInsightsOperations
[ChangeLog]   - Removed operation group SavedSearchesOperations

azure-pipelines · 2020-03-15T08:37:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-15T08:37:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-15T14:28:38Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-15T14:36:30Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-16T06:36:56Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-16T07:19:06Z

Azure Pipelines successfully started running 1 pipeline(s).

orargaman · 2020-03-16T14:09:39Z

Currently the BreakingChange Test is failing on the cluster API’s. Those APIS are in private preview and are only used by two customers. Both those customers are aware of the changes in the API and are currently using it as shown in my updates.

PhoenixHe-NV · 2020-03-16T14:24:53Z

/azp run

azure-pipelines · 2020-03-16T14:25:13Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-03-16T14:29:54Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

...ghts/resource-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/Clusters.json

...ce-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/OperationalInsights.json

...ghts/resource-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/Clusters.json

pilor

Question about sku capacity

azure-pipelines · 2020-03-24T08:47:20Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-03-25T04:31:51Z

@jianyexi Why we report error in breakingchange in preview API? Could you please help to have a look?

jianyexi · 2020-03-25T05:38:41Z

@jianyexi Why we report error in breakingchange in preview API? Could you please help to have a look?

currently , breaking-change does not distinguish between preview API and stable API

PhoenixHe-NV · 2020-03-25T05:57:08Z

@jianyexi But breaking change in preview api is allowed and should not block PR from merging. @akning-ms We need to make change and unblock this right?

azure-pipelines · 2020-03-25T11:09:19Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-03-26T03:20:50Z

@akning-ms Please help to merge this PR. All the breaking change happens in preview API.

yoramsinger · 2020-03-26T19:25:59Z

@akning-ms please merge this PR. Thanks.

...esource-manager/Microsoft.OperationalInsights/preview/2015-11-01-preview/LinkedServices.json

azure-pipelines · 2020-03-27T08:39:53Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-29T15:21:15Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-03-30T02:23:19Z

@akning-ms Please help to merge this PR

* Update cluster and linked services API * Update LinkedServicesGet.json Fix * fix json * Prettier * fix modelValidation * fix modelValidation 2 * Fixes for PR * separate linkedServices to new file * Update readme.md * Fix PR * Change capacityReservationLevel to capacity * Fix version * writeAccessResourceId fix camel case Co-authored-by: Or Argaman <orargama@microsoft.com>

Update cluster and linked services API

6e58ceb

openapi-assignment-bot bot assigned PhoenixHe-NV Mar 11, 2020

Update LinkedServicesGet.json

05e02fe

Fix

fix json

f14df7e

Prettier

0375be4

fix modelValidation

f8fa3fb

fix modelValidation 2

b506fb4

akning-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 16, 2020

anthony-c-martin requested changes Mar 17, 2020

View reviewed changes

Fixes for PR

8db1a1d

pilor added the ARMReviewInProgress label Mar 23, 2020

pilor reviewed Mar 23, 2020

View reviewed changes

...ghts/resource-manager/Microsoft.OperationalInsights/preview/2019-08-01-preview/Clusters.json Show resolved Hide resolved

pilor added ARMChangesRequested and removed ARMReviewInProgress labels Mar 23, 2020

pilor suggested changes Mar 23, 2020

View reviewed changes

Fix PR

7771f83

Change capacityReservationLevel to capacity

29f6abd

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 25, 2020

pilor approved these changes Mar 25, 2020

View reviewed changes

PhoenixHe-NV approved these changes Mar 26, 2020

View reviewed changes

PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 26, 2020

mmyyrroonn suggested changes Mar 27, 2020

View reviewed changes

...esource-manager/Microsoft.OperationalInsights/preview/2015-11-01-preview/LinkedServices.json Outdated Show resolved Hide resolved

Fix version

ab8659a

orargaman requested a review from mmyyrroonn March 27, 2020 08:41

writeAccessResourceId fix camel case

8210d51

mmyyrroonn approved these changes Mar 30, 2020

View reviewed changes

akning-ms merged commit 64541c6 into Azure:master Mar 30, 2020

Conversation

orargaman commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Mar 11, 2020

Uh oh!

azuresdkci commented Mar 11, 2020

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

- Breaking Change detected in SDK

Uh oh!

azure-pipelines bot commented Mar 15, 2020

Uh oh!

azure-pipelines bot commented Mar 15, 2020

Uh oh!

azure-pipelines bot commented Mar 15, 2020

Uh oh!

azure-pipelines bot commented Mar 15, 2020

Uh oh!

azure-pipelines bot commented Mar 16, 2020

Uh oh!

azure-pipelines bot commented Mar 16, 2020

Uh oh!

orargaman commented Mar 16, 2020

Uh oh!

PhoenixHe-NV commented Mar 16, 2020

Uh oh!

azure-pipelines bot commented Mar 16, 2020

Uh oh!

openapi-sdkautomation bot commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-cli-extensions - Release

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pilor left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Mar 24, 2020

Uh oh!

PhoenixHe-NV commented Mar 25, 2020

Uh oh!

jianyexi commented Mar 25, 2020

Uh oh!

PhoenixHe-NV commented Mar 25, 2020

Uh oh!

azure-pipelines bot commented Mar 25, 2020

Uh oh!

PhoenixHe-NV commented Mar 26, 2020

Uh oh!

yoramsinger commented Mar 26, 2020

Uh oh!

Uh oh!

azure-pipelines bot commented Mar 27, 2020

Uh oh!

azure-pipelines bot commented Mar 29, 2020

Uh oh!

orargaman commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 16, 2020 •

edited

Loading